Skip to content

fix(algo): gate icebug behind ICEBUG_ENABLED, fail soft on download error - #50

Merged
adsharma merged 1 commit into
mainfrom
icebug_build_fix
Aug 9, 2026
Merged

fix(algo): gate icebug behind ICEBUG_ENABLED, fail soft on download error#50
adsharma merged 1 commit into
mainfrom
icebug_build_fix

Conversation

@adsharma

@adsharma adsharma commented Aug 9, 2026

Copy link
Copy Markdown
Contributor
  • Top-level CMakeLists adds option(ICEBUG_ENABLED ON) so icebug can be disabled explicitly (-DICEBUG_ENABLED=OFF) or as a fallback when the GitHub prebuilt download fails (offline CI, rate limit, etc.).
  • download_icebug.cmake early-returns on -DICEBUG_ENABLED=OFF and, on a failed file(DOWNLOAD), emits a WARNING, flips ICEBUG_ENABLED to OFF (FORCE'd so re-configures don't re-fail), and returns with empty ICEBUG_* vars instead of fatal-erroring configure.
  • Top-level CMakeLists gates find_package(Arrow), the icebug include dirs, lib linkage, and rpath behind ICEBUG_ENABLED. find_package(OpenMP) stays unconditional (other algos use <omp.h>).
  • function/CMakeLists drops gds_page_rank.cpp + Arrow::arrow_shared when disabled; main/CMakeLists + algo_extension.cpp gate the GDS_PAGE_RANK registration and ARROW_DEFAULT_MEMORY_POOL setup behind #ifdef ICEBUG_ENABLED via target_compile_definitions.

…rror

- Top-level CMakeLists adds option(ICEBUG_ENABLED ON) so icebug can be
  disabled explicitly (-DICEBUG_ENABLED=OFF) or as a fallback when the
  GitHub prebuilt download fails (offline CI, rate limit, etc.).
- download_icebug.cmake early-returns on -DICEBUG_ENABLED=OFF and, on a
  failed file(DOWNLOAD), emits a WARNING, flips ICEBUG_ENABLED to OFF
  (FORCE'd so re-configures don't re-fail), and returns with empty
  ICEBUG_* vars instead of fatal-erroring configure.
- Top-level CMakeLists gates find_package(Arrow), the icebug include
  dirs, lib linkage, and rpath behind ICEBUG_ENABLED. find_package(OpenMP)
  stays unconditional (other algos use <omp.h>).
- function/CMakeLists drops gds_page_rank.cpp + Arrow::arrow_shared when
  disabled; main/CMakeLists + algo_extension.cpp gate the GDS_PAGE_RANK
  registration and ARROW_DEFAULT_MEMORY_POOL setup behind #ifdef
  ICEBUG_ENABLED via target_compile_definitions.
@adsharma
adsharma merged commit f1d1dfb into main Aug 9, 2026
2 checks passed
@adsharma
adsharma deleted the icebug_build_fix branch August 9, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant