fix(algo): gate icebug behind ICEBUG_ENABLED, fail soft on download error - #50
Merged
Conversation
adsharma
commented
Aug 9, 2026
Contributor
- Top-level CMakeLists adds option(ICEBUG_ENABLED ON) so icebug can be disabled explicitly (-DICEBUG_ENABLED=OFF) or as a fallback when the GitHub prebuilt download fails (offline CI, rate limit, etc.).
- download_icebug.cmake early-returns on -DICEBUG_ENABLED=OFF and, on a failed file(DOWNLOAD), emits a WARNING, flips ICEBUG_ENABLED to OFF (FORCE'd so re-configures don't re-fail), and returns with empty ICEBUG_* vars instead of fatal-erroring configure.
- Top-level CMakeLists gates find_package(Arrow), the icebug include dirs, lib linkage, and rpath behind ICEBUG_ENABLED. find_package(OpenMP) stays unconditional (other algos use <omp.h>).
- function/CMakeLists drops gds_page_rank.cpp + Arrow::arrow_shared when disabled; main/CMakeLists + algo_extension.cpp gate the GDS_PAGE_RANK registration and ARROW_DEFAULT_MEMORY_POOL setup behind #ifdef ICEBUG_ENABLED via target_compile_definitions.
…rror - Top-level CMakeLists adds option(ICEBUG_ENABLED ON) so icebug can be disabled explicitly (-DICEBUG_ENABLED=OFF) or as a fallback when the GitHub prebuilt download fails (offline CI, rate limit, etc.). - download_icebug.cmake early-returns on -DICEBUG_ENABLED=OFF and, on a failed file(DOWNLOAD), emits a WARNING, flips ICEBUG_ENABLED to OFF (FORCE'd so re-configures don't re-fail), and returns with empty ICEBUG_* vars instead of fatal-erroring configure. - Top-level CMakeLists gates find_package(Arrow), the icebug include dirs, lib linkage, and rpath behind ICEBUG_ENABLED. find_package(OpenMP) stays unconditional (other algos use <omp.h>). - function/CMakeLists drops gds_page_rank.cpp + Arrow::arrow_shared when disabled; main/CMakeLists + algo_extension.cpp gate the GDS_PAGE_RANK registration and ARROW_DEFAULT_MEMORY_POOL setup behind #ifdef ICEBUG_ENABLED via target_compile_definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.